Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design doc for Audit MVP #1801

Merged
merged 16 commits into from
Feb 28, 2024
Merged

Design doc for Audit MVP #1801

merged 16 commits into from
Feb 28, 2024

Conversation

waxlamp
Copy link
Member

@waxlamp waxlamp commented Jan 2, 2024 •
edited
Loading

Closes #525.

@waxlamp waxlamp self-assigned this Jan 2, 2024
satra
satra reviewed Jan 2, 2024
View reviewed changes
doc/design/audit-trail-mvp.md Show resolved Hide resolved
doc/design/audit-trail-mvp.md Outdated Show resolved Hide resolved
yarikoptic
yarikoptic reviewed Jan 5, 2024
View reviewed changes
.codespellrc Outdated Show resolved Hide resolved
yarikoptic
yarikoptic requested changes Jan 7, 2024
View reviewed changes
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial changes, yet to finish reading.

doc/design/audit-trail-mvp.md Show resolved Hide resolved
doc/design/audit-trail-mvp.md Show resolved Hide resolved
doc/design/audit-trail-mvp.md Show resolved Hide resolved
doc/design/audit-trail-mvp.md Outdated Show resolved Hide resolved
doc/design/audit-trail-mvp.md Outdated Show resolved Hide resolved
doc/design/audit-trail-mvp.md Outdated Show resolved Hide resolved
doc/design/audit-trail-mvp.md Outdated Show resolved Hide resolved
doc/design/audit-trail-mvp.md Outdated Show resolved Hide resolved
waxlamp and others added 4 commits January 23, 2024 22:42
@waxlamp @yarikoptic
Include asset_id in "add asset" specific data
a59908c 
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
@waxlamp @yarikoptic
Include old and new asset IDs in "update asset" data
340df2b 
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
@waxlamp @yarikoptic
Include asset_id in "remove asset" data
c3854ff 
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
@waxlamp
Use correct terminology
a9a5e43
@waxlamp @yarikoptic
Include zarr_id in spec for asset operations
fe5e80d 
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
@waxlamp waxlamp merged commit e0d0b91 into master Feb 28, 2024
11 checks passed
@waxlamp waxlamp deleted the audit-design-doc branch February 28, 2024 15:31
@dandibot
Copy link
Member

🚀 PR was released in v0.3.77 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic requested changes

@jwodder jwodder jwodder left review comments

@satra satra satra left review comments

@bendichter bendichter bendichter left review comments

@kabilar kabilar kabilar left review comments

@aaronkanzer aaronkanzer aaronkanzer left review comments

Assignees

@waxlamp waxlamp

Labels
released This issue/pull request has been released.
Projects
DANDI Initiatives
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write design docs for internal and external audit functionality
8 participants
@waxlamp @dandibot @yarikoptic @jwodder @satra @bendichter @kabilar @aaronkanzer