Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test_create_dev_dandiset #1070

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Fix failing test_create_dev_dandiset #1070

merged 2 commits into from
Apr 29, 2022

Conversation

jjnesbitt
Copy link
Member

@jjnesbitt jjnesbitt commented Apr 27, 2022

Closes #1065

@jjnesbitt jjnesbitt force-pushed the 1065-failing-tests branch 2 times, most recently from 5d12608 to 9f8098d Compare April 27, 2022 19:40
@jjnesbitt jjnesbitt changed the title [TEST] Use different dandi-schema branch Fix failing test_create_dev_dandiset Apr 27, 2022
@jjnesbitt jjnesbitt marked this pull request as ready for review April 28, 2022 18:34
The `safe_email` Faker provider always uses `example.(net|com|org)` as
the email domain. For some reason, this causes validation errors with
dandischema.
@jjnesbitt jjnesbitt merged commit 3794e59 into master Apr 29, 2022
@jjnesbitt jjnesbitt deleted the 1065-failing-tests branch April 29, 2022 20:12
@dandibot
Copy link
Member

🚀 PR was released in v0.2.18 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing tests
3 participants