Pin django-oauth-toolkit to 1.x #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlmightyYakob, is this the same CI failure you've been dealing with lately? (valid email addresses not passing validation?) |
Yep |
jjnesbitt
approved these changes
Apr 28, 2022
|
I think we can merge this, and I'll rebase #1070 off of master so that PR will fix the final CI failure. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade to 2.0.0 caused the check-migrations test to fail since one of the breaking changes was to change the DB schema. I'm pinning this to 1.x now to prevent breakage in production, but this opens up two issues:
Thoughts on the above welcome.