Improve manifest file writing performance #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
force-pushed
the
fix-manifest-performance
branch
from
9ad433c
to
592dc3d
Compare
mvandenburgh
approved these changes
Jul 19, 2022
mvandenburgh
added
patch
|
@danlamanna you'll also need to remove the resource from Terraform (https://github.com/dandi/dandi-infrastructure/blob/master/terraform/api.tf#L56-L61) after this PR is released. |
|
🚀 PR was released in |
brianhelba
added a commit
that referenced
this pull request
Nov 6, 2023
This follows #1184, but reduces unnecessary re-encodings from bytes to strings. It also cleans up the "manifest.py" module, by making more of the API private and adding additional type annotations.
brianhelba
added a commit
that referenced
this pull request
Nov 6, 2023
This follows #1184, but reduces unnecessary re-encodings from bytes to strings. It also cleans up the "manifest.py" module, by making more of the API private and adding additional type annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly speeds up and reduces the memory usage of the write_manifest_files task that takes place on publish.
The manifest files are now written in a streaming fashion, and the YAML output now uses the C implementation. Worst case time/memory usage went from ~2m20s and ~1gb ram to ~20s and ~25mb (constant time) memory usage.
As a result, I'm removing the manifest-worker since this task doesn't need to be treated differently than any others on the main worker.
Fixes #985