Clean up and improve the performance of manifest file creation #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows #1184, but reduces unnecessary re-encodings from bytes to strings. It also cleans up the "manifest.py" module, by making more of the API private and adding additional type annotations.
brianhelba
force-pushed
the
streaming-upload
branch
from
a1ae2a2
to
1296df7
Compare
danlamanna
approved these changes
Nov 9, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #1184, but reduces unnecessary re-encodings from bytes to strings. It also cleans up the
manifest.pymodule, by making more of the API private and adding additional type annotations.