Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github username + profile link to UI #1504

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Add github username + profile link to UI #1504

merged 1 commit into from
Apr 11, 2023

Conversation

mvandenburgh
Copy link
Member

Closes #1481

@danlamanna
Copy link
Contributor

Should this be in a textbox? 🤷‍♂️

@waxlamp
Copy link
Member

waxlamp commented Mar 10, 2023

Should this be in a textbox? man_shrugging

@mvandenburgh, instead of a textbox, can we convert it to a single sentence like You are logged in as waxlamp., with waxlamp a hyperlink to the GitHub profile? I'm open to other phrasings, but a natural language flow would be better than a textbox mirroring the API key UI.

@mvandenburgh
Copy link
Member Author

oops, didn't mean to close this

@mvandenburgh mvandenburgh reopened this Apr 3, 2023
@mvandenburgh mvandenburgh added patch Increment the patch version when merged release Create a release when this pr is merged labels Apr 11, 2023
@mvandenburgh mvandenburgh merged commit c84dc8d into master Apr 11, 2023
@mvandenburgh mvandenburgh deleted the add-github-username-to-ui branch April 11, 2023 21:52
@dandibot
Copy link
Member

🚀 PR was released in v0.3.30 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlamanna danlamanna danlamanna approved these changes

@waxlamp waxlamp waxlamp approved these changes

@marySalvi marySalvi Awaiting requested review from marySalvi

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request: show GitHub username in login dropdown
4 participants
@mvandenburgh @danlamanna @waxlamp @dandibot