Add download count tracking to asset blobs #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
force-pushed
the
asset-download-counts
branch
from
bb6aedd
to
5f1225d
Compare
jjnesbitt
reviewed
Apr 11, 2023
danlamanna
force-pushed
the
asset-download-counts
branch
2 times, most recently
from
c6c658c
to
fb4ebf7
Compare
mvandenburgh
approved these changes
Apr 11, 2023
jjnesbitt
approved these changes
Apr 12, 2023
danlamanna
force-pushed
the
asset-download-counts
branch
from
9d0d794
to
fb4ebf7
Compare
danlamanna
force-pushed
the
asset-download-counts
branch
from
fb4ebf7
to
bb772aa
Compare
yarikoptic
reviewed
May 5, 2023
danlamanna
force-pushed
the
asset-download-counts
branch
from
bb772aa
to
f0c64ba
Compare
danlamanna
force-pushed
the
asset-download-counts
branch
from
f0c64ba
to
6841360
Compare
danlamanna
added
patch
|
🚀 PR was released in |
yarikoptic
reviewed
May 15, 2023
| @@ -56,6 +56,7 @@ class BaseAssetBlob(TimeStampedModel): | |||
| ) | |||
| etag = models.CharField(max_length=40, validators=[RegexValidator(f'^{ETAG_REGEX}$')]) | |||
| size = models.PositiveBigIntegerField() | |||
| download_count = models.PositiveBigIntegerField(default=0) | |||
There was a problem hiding this comment.
where in the API could I see/get those?
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1424.
This PR adds S3 server-side log processing to track the number of downloads per asset blob. The plan is to do an initial ingest and then set up a scheduled beat task to run this at some interval. For now, this increments the counters in the database and avoids exposing it in the GUI or aggregating these figures anywhere.