Fix S3 log file processing #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
added
patch
danlamanna
force-pushed
the
s3-log-processing-fix
branch
from
35a5d9b
to
58b3ee0
Compare
danlamanna
force-pushed
the
s3-log-processing-fix
branch
from
58b3ee0
to
6913d7e
Compare
mvandenburgh
approved these changes
May 26, 2023
danlamanna
force-pushed
the
s3-log-processing-fix
branch
from
ac9e8c1
to
6913d7e
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e286ef8, and is follow on work from #1570.
The comments should explain the main points, but this should remove the deadlocking issues and silence the duplicate log file exceptions that were bubbling up to Sentry (while preserving legitimate errors).