Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove excess rows to fix responsive view of stats bar #1633

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Remove excess rows to fix responsive view of stats bar #1633

merged 1 commit into from
Jun 21, 2023

Conversation

marySalvi
Copy link
Contributor

fixes #1611
Removes excess rows and adjusts props for remaining rows to fix the responsive view of stats bar. Phone view shown below.

image

@marySalvi
Copy link
Contributor Author

marySalvi commented Jun 21, 2023 •
edited
Loading

@satra Please note the screenshot

mvandenburgh
mvandenburgh approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on a couple of the phone-sized viewports in the chrome dev tools and it responds as expected.

@marySalvi marySalvi merged commit 4f4f0e5 into master Jun 21, 2023
2 checks passed
@marySalvi marySalvi deleted the status-ui branch June 21, 2023 19:31
waxlamp
waxlamp reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dandibot
Copy link
Member

🚀 PR was released in v0.3.45 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jun 26, 2023
@jjnesbitt jjnesbitt mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waxlamp waxlamp waxlamp left review comments

@mvandenburgh mvandenburgh mvandenburgh approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI off on main page
4 participants
@marySalvi @dandibot @waxlamp @mvandenburgh