Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove excess rows to fix responsive view of stats bar #1633

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Remove excess rows to fix responsive view of stats bar #1633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions web/src/views/HomeView/HomeView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@
<DandisetSearchField :dense="false" />
</v-col>
</v-row>
<v-row class="flex-grow-0">
<StatsBar />
</v-row>
<StatsBar />
</v-container>
</template>

Expand Down
19 changes: 10 additions & 9 deletions web/src/views/HomeView/SingleStat.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
<template>
<v-container
fluid
class="py-0 px-8"
data-id="stat"
:data-name="name"
>
<v-row class="text-h3 font-weight-thin text-center white--text">
<div>
<v-row
class="text-h3 font-weight-thin text-center white--text"
no-gutters
>
<v-col
class="pa-0"
data-id="value"
>
{{ value }}
</v-col>
</v-row>
<v-row class="text-h6 font-weight-light text-center light-blue--text text--lighten-1">
<v-row
class="text-h6 font-weight-light text-center light-blue--text text--lighten-1"
no-gutters
>
<v-col
class="pa-0"
data-id="name"
Expand Down Expand Up @@ -43,7 +44,7 @@
</v-tooltip>
</v-col>
</v-row>
</v-container>
</div>
</template>

<script lang="ts">
Expand Down
9 changes: 1 addition & 8 deletions web/src/views/HomeView/StatsBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class="grey darken-3 pa-0"
fluid
>
<v-row class="py-6">
<v-row class="py-6 mt-2">
<template v-for="stat in stats">
<v-col
:key="stat.name"
Expand All @@ -19,13 +19,6 @@
:href="stat.href"
/>
</v-col>
<!-- TODO dividers destroy the grid system breakpoints
<v-divider
:key="stat.name + '-divider'"
vertical
class="grey"
/>
-->
</template>
</v-row>
</v-container>
Expand Down