Fix possible race condition in deployment actions #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
approved these changes
Sep 15, 2023
mvandenburgh
force-pushed
the
fix-deploy-actions
branch
from
9b4fb25
to
1087222
Compare
|
Neat. @mvandenburgh how did you know to fix this problem? |
We ran into this issue on SMART, where we also use GitHub Actions for deployment. On that project deploys usually take about 30 mins, so this issue was somewhat common since merging multiple PRs in the same 30 minute window would potentially cause it to happen. |
|
🚀 PR was released in |
waxlamp
added a commit
that referenced
this pull request
Oct 5, 2023
After #1679, the staging deploy that occurs during a release merge gets interrupted by a second staging deploy triggered by `auto`'s push to master containing the updated `CHANGELOG.md`. This PR prevents that second deploy from running, avoiding a spurious deploy failure that happens when the first deploy is canceled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't enforce any
concurrencyrule on the github actions that deploy our Django app to Heroku. This opens us up to potential issues, such as a scenario where an older deploy job ends up running after a newer job, causing the older version of the app to "overwrite" the newer one on Heroku.