Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent CHANGELOG.md from triggering staging deploy #1699

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

waxlamp
Copy link
Member

@waxlamp waxlamp commented Oct 5, 2023

After #1679, the staging deploy that occurs during a release merge gets interrupted by a second staging deploy triggered by auto's push to master containing the updated CHANGELOG.md.

This PR prevents that second deploy from running, avoiding a spurious deploy failure that happens when the first deploy is canceled.

Thanks to @mvandenburgh for helping me debug this problem.

After #1679, the staging deploy that occurs during a release merge gets interrupted by a second staging deploy triggered by `auto`'s push to master containing the updated `CHANGELOG.md`.

This PR prevents that second deploy from running, avoiding a spurious deploy failure that happens when the first deploy is canceled.
@waxlamp waxlamp merged commit 6c959f6 into master Oct 5, 2023
10 checks passed
@waxlamp waxlamp deleted the fix-spurious-deploy-failure branch October 5, 2023 19:31
@dandibot
Copy link
Member

🚀 PR was released in v0.3.56 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants