Remove unused modified field on Upload model
#1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
remove-modified-field-upload
branch
from
485df0f
to
4ef2e71
Compare
mvandenburgh
commented
Oct 16, 2023
Comment on lines
+21
to
+30
| migrations.AlterField( | ||
| model_name='embargoedupload', | ||
| name='created', | ||
| field=django_extensions.db.fields.CreationDateTimeField(auto_now_add=True), | ||
| ), | ||
| migrations.AlterField( | ||
| model_name='upload', | ||
| name='created', | ||
| field=django_extensions.db.fields.CreationDateTimeField(auto_now_add=True), | ||
| ), |
There was a problem hiding this comment.
Note: this migration got created because TimeStampedModel defines created internally a bit differently using gettext_lazy https://github.com/django-extensions/django-extensions/blob/main/django_extensions/db/models.py#L17
|
#1714 will fix the failing type check here. |
mvandenburgh
force-pushed
the
remove-modified-field-upload
branch
from
4ef2e71
to
ece150e
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while investigating what new fields (if any) we need to add for garbage collection of
Uploads. We don't use this anywhere at this time, and since we've already decided to rework how we domodified(not usingTimeStampedModel), I think it makes sense to just remove this.