Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix requests type errors #1714

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix requests type errors #1714

merged 1 commit into from
Oct 16, 2023

Conversation

mvandenburgh
Copy link
Member

A recent release of requests changed the type of requests.exceptions.HTTPError.response from Response to Response | None, so it's now necessary to check if HTTPError.response is None before inspecting it.

This will fix the mypy failures on master.

@mvandenburgh mvandenburgh mentioned this pull request Oct 16, 2023
Merged
@mvandenburgh mvandenburgh merged commit d68207c into master Oct 16, 2023
8 of 10 checks passed
@mvandenburgh mvandenburgh deleted the fix-type-errors branch October 16, 2023 19:16
@dandibot
Copy link
Member

🚀 PR was released in v0.3.58 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlamanna danlamanna danlamanna approved these changes

@jjnesbitt jjnesbitt Awaiting requested review from jjnesbitt

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvandenburgh @dandibot @danlamanna