Fix publish #460
Merged
Fix publish #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Asset.published_asset()` created a new `Asset`, which is not how publishing `Asset`s should work. Instead, the `Asset` should be modified in place, which is what `publish()` does. `published_metadata()` is also added so that the validation task can get the metadata of the published `Asset` without actually modifying the `Asset`.
There are meaningful differences in how draft and published `Assets` behave, so it makes sense to have two separate test factories. The `asset` and `asset_factory` fixtures are still available, they simply run the test twice, once with a draft asset and once with a published asset.
This test verifies that both draft and published assets are published properly.
dchiquito
commented
Aug 6, 2021
| return published_asset | ||
| This is useful to validate asset metadata without saving it. | ||
| To actually publish this Asset, simply save() after calling publish(). | ||
| """ |
There was a problem hiding this comment.
document the link to bulk_update
waxlamp
approved these changes
Aug 6, 2021
mvandenburgh
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #459
AssetFactoryintoDraftAssetFactoryandPublishedAssetFactory