Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publish #460

Merged
merged 5 commits into from
Aug 6, 2021
Merged

Fix publish #460

merged 5 commits into from
Aug 6, 2021

Commits on Aug 6, 2021

  1. Conver Asset.published_asset() into published_metadata() and publish() 

    `Asset.published_asset()` created a new `Asset`, which is not how
publishing `Asset`s should work. Instead, the `Asset` should be modified
in place, which is what `publish()` does.
`published_metadata()` is also added so that the validation task can get
the metadata of the published `Asset` without actually modifying the
`Asset`.
    @dchiquito
    dchiquito committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    48ee63f View commit details
    Browse the repository at this point in the history

  2. Split AssetFactory in DraftAssetFactory and PublishedAssetFactory 

    There are meaningful differences in how draft and published `Assets`
behave, so it makes sense to have two separate test factories.

The `asset` and `asset_factory` fixtures are still available, they
simply run the test twice, once with a draft asset and once with a
published asset.
    @dchiquito
    dchiquito committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    e72507d View commit details
    Browse the repository at this point in the history

  3. Use new asset factories in tests

    @dchiquito
    dchiquito committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    da57b2c View commit details
    Browse the repository at this point in the history

  4. Add new publish test 

    This test verifies that both draft and published assets are published
properly.
    @dchiquito
    dchiquito committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    4dbb975 View commit details
    Browse the repository at this point in the history

  5. Add documentation for maintaining publish bulk_update

    @dchiquito
    dchiquito committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    5ff021c View commit details
    Browse the repository at this point in the history