Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env var to disable docker-compose pull in the fixture #1140

Closed
yarikoptic opened this issue Oct 21, 2022 · 1 comment · Fixed by #1141
Closed

Add env var to disable docker-compose pull in the fixture #1140

yarikoptic opened this issue Oct 21, 2022 · 1 comment · Fixed by #1141
Assignees
@jwodder
Labels
released

Comments

@yarikoptic
Copy link
Member

We already have DANDI_TESTS_PERSIST_DOCKER_COMPOSE and let's add DANDI_TESTS_PULL_DOCKER_COMPOSE (or anything else really) which would default to 1 but allow for 0 and then would be used as a bool (or some other way allowing to disable) to disable docker compose pull introduced in #1121 to fix #1120 and which lead to dandi-archive integration testing not using freshly built docker image as discovered in dandi/dandi-archive#1336 (comment) .
@yarikoptic yarikoptic mentioned this issue Oct 21, 2022
Closed
@jwodder jwodder mentioned this issue Oct 21, 2022
Merged
yarikoptic added a commit that referenced this issue Oct 21, 2022
@yarikoptic
Merge pull request #1141 from dandi/gh-1140
4c4fa5f 
Add `DANDI_TESTS_PULL_DOCKER_COMPOSE` envvar
@github-actions
Copy link

🚀 Issue was released in 0.46.6 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwodder jwodder

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add DANDI_TESTS_PULL_DOCKER_COMPOSE envvar dandi/dandi-cli
2 participants
@yarikoptic @jwodder