Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DANDI_TESTS_PULL_DOCKER_COMPOSE envvar #1141

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Add DANDI_TESTS_PULL_DOCKER_COMPOSE envvar #1141

merged 1 commit into from
Oct 21, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 21, 2022

Closes #1140.

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 87.93% // Head: 62.78% // Decreases project coverage by -25.14% ⚠️

Coverage data is based on head (18edf40) compared to base (26fa719).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1141       +/-   ##
===========================================
- Coverage   87.93%   62.78%   -25.15%     
===========================================
  Files          73       73               
  Lines        8585     8586        +1     
===========================================
- Hits         7549     5391     -2158     
- Misses       1036     3195     +2159     
Flag Coverage Δ
unittests 62.78% <0.00%> (-25.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/fixtures.py 72.79% <0.00%> (-25.28%) ⬇️
dandi/tests/test_upload.py 19.35% <0.00%> (-80.65%) ⬇️
dandi/tests/test_delete.py 22.69% <0.00%> (-77.31%) ⬇️
dandi/upload.py 9.13% <0.00%> (-76.65%) ⬇️
dandi/tests/test_helpers.py 25.00% <0.00%> (-75.00%) ⬇️
dandi/cli/tests/test_service_scripts.py 25.00% <0.00%> (-75.00%) ⬇️
dandi/tests/test_dandiapi.py 25.22% <0.00%> (-73.24%) ⬇️
dandi/delete.py 30.51% <0.00%> (-60.39%) ⬇️
dandi/move.py 33.09% <0.00%> (-58.76%) ⬇️
dandi/tests/test_dandiarchive.py 41.66% <0.00%> (-58.34%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Do we need a release to take advantage of this in dandi-archive testing? if so -- please add release label and merge

@yarikoptic
Copy link
Member

answering my own question since was looking at that workflow anyways -- we do want release since we test against both dev and release, thus adding the label

@jwodder
Copy link
Member Author

jwodder commented Oct 21, 2022

@yarikoptic Dandi Archive tests against both the latest release of dandi-cli and against the master branch, so a release isn't really needed.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Oct 21, 2022
@yarikoptic
Copy link
Member

;-) indeed the fact that we test against both could be treated the other way as well (that no release is needed). But I think we better re-establish the common base now, so I will keep the release label and can be merged as ubuntu CI runs complete

@yarikoptic
Copy link
Member

hm, testing is failing but likely due to the dandi-archive introducing breaking change and this PR trying to allow to avoid that in the future. I do not see how this could add breakage, so will merge

@yarikoptic yarikoptic merged commit 4c4fa5f into master Oct 21, 2022
@yarikoptic yarikoptic deleted the gh-1140 branch October 21, 2022 19:05
@github-actions
Copy link

🚀 PR was released in 0.46.6 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this pr is merged released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add env var to disable docker-compose pull in the fixture
2 participants