Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client-side publication workflow #1125

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Update client-side publication workflow #1125

merged 1 commit into from
Oct 6, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 5, 2022

Closes #1119.

@jwodder jwodder added the internal Changes only affect the internal API label Oct 5, 2022
@jwodder
Copy link
Member Author

jwodder commented Oct 5, 2022

According to https://www.githubstatus.com, GitHub Actions is currently experiencing problems, so it may take a while for the CI to be triggered.

@yarikoptic
Copy link
Member

@jwodder - could you please resubmit to retrigger CI? github health is back to green but I guess "what is missed remains missed"

@jwodder
Copy link
Member Author

jwodder commented Oct 5, 2022

@yarikoptic Done.

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 87.91% // Head: 87.90% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (e24d324) compared to base (e021829).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
- Coverage   87.91%   87.90%   -0.01%     
==========================================
  Files          73       73              
  Lines        8549     8569      +20     
==========================================
+ Hits         7516     7533      +17     
- Misses       1033     1036       +3     
Flag Coverage Δ
unittests 87.90% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 88.10% <86.95%> (+0.03%) ⬆️
dandi/tests/test_dandiapi.py 98.45% <100.00%> (+<0.01%) ⬆️
dandi/support/threaded_walk.py 92.85% <0.00%> (-1.79%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide order only if provided and not provide None for the value?

v = Version.parse_obj(self.client.get(f"{draft_api_path}info/"))
if v.status is VersionStatus.PUBLISHED:
break
sleep(0.5)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not thrilled about up to 240 requests to time out, but I guess that is the life.

dandi/dandiapi.py Show resolved Hide resolved
@yarikoptic yarikoptic added the release Create a release when this pr is merged label Oct 6, 2022
@yarikoptic yarikoptic merged commit fd0dd09 into master Oct 6, 2022
@yarikoptic yarikoptic deleted the gh-1119 branch October 6, 2022 15:56
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

🚀 PR was released in 0.46.4 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new publishing workflow
2 participants