Update for change to publication workflow #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 77.57% // Head: 77.31% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## draft #277 +/- ##
==========================================
- Coverage 77.57% 77.31% -0.27%
==========================================
Files 14 14
Lines 2087 2098 +11
Branches 343 346 +3
==========================================
+ Hits 1619 1622 +3
- Misses 337 340 +3
- Partials 131 136 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yarikoptic
reviewed
Oct 6, 2022
| log.debug( | ||
| "Waiting for Dandiset %s to complete publication ...", self.identifier | ||
| ) | ||
| start = time() |
There was a problem hiding this comment.
we might benefit from starting to use https://pypi.org/project/polling2/ at some point
|
It's green, let's proceed, thank you @jwodder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to dandi/dandi-cli#1125