Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict mypy to pre-v1.1.1 #1246

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Restrict mypy to pre-v1.1.1 #1246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ commands =

[testenv:typing]
deps =
mypy
mypy<1.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward for a fix, and presumably already fixed in pydantic/pydantic#5111 (could you check may be), should we just

Suggested change
mypy<1.1.1
mypy!=1.1.1

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< is slightly better, in the case where mypy releases a new version before pydantic does.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's proceed but later change when know which needed or to be avoided

types-appdirs
types-python-dateutil
types-requests
Expand Down