Restrict mypy to pre-v1.1.1 #1246
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1246 +/- ##
==========================================
- Coverage 89.04% 89.03% -0.02%
==========================================
Files 76 76
Lines 9698 9698
==========================================
- Hits 8636 8635 -1
- Misses 1062 1063 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -28,7 +28,7 @@ commands = | |||
|
|
|||
| [testenv:typing] | |||
| deps = | |||
| mypy | |||
| mypy<1.1.1 | |||
There was a problem hiding this comment.
looking forward for a fix, and presumably already fixed in pydantic/pydantic#5111 (could you check may be), should we just
| mypy<1.1.1 | |
| mypy!=1.1.1 |
?
There was a problem hiding this comment.
< is slightly better, in the case where mypy releases a new version before pydantic does.
There was a problem hiding this comment.
Ok, let's proceed but later change when know which needed or to be avoided
|
🚀 PR was released in |
Type-checking of pydantic types is broken in many respects under mypy 1.1.1 (See pydantic/pydantic#5148), so until pydantic publishes a new release with a fix, we need to use an older mypy in order to get type-checking to pass.