Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Restrict mypy to pre-v1.1.1" #1247

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Revert "Restrict mypy to pre-v1.1.1" #1247

merged 1 commit into from
Mar 9, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 9, 2023

This reverts commit 042eff5 / #1246.

Pydantic 1.10.6, released yesterday, fixes the mypy integration.

@jwodder jwodder added the tests Add or improve existing tests label Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (39a41df) 89.03% compared to head (6cca4b4) 89.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
- Coverage   89.03%   89.01%   -0.03%     
==========================================
  Files          76       76              
  Lines        9698     9698              
==========================================
- Hits         8635     8633       -2     
- Misses       1063     1065       +2     
Flag Coverage Δ
unittests 89.01% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/misctypes.py 72.54% <0.00%> (-0.66%) ⬇️
dandi/metadata.py 89.22% <0.00%> (-0.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic merged commit 3fa41e7 into master Mar 9, 2023
@yarikoptic yarikoptic deleted the unrestrict-mypy branch March 9, 2023 19:40
@github-actions
Copy link

🚀 PR was released in 0.51.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants