Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't output table if no violations are specified #116

Merged
merged 5 commits into from
Jan 29, 2017
Merged

Don't output table if no violations are specified #116

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28a8f60
Don't output table if no violations are specified
mxstbr Jan 29, 2017
c9b9d7f
Update CHANGELOG
mxstbr Jan 29, 2017
daa8c73
Add tests for new behaviour
mxstbr Jan 29, 2017
cddd762
Update CHANGELOG
mxstbr Jan 29, 2017
f156775
Fix for multiple empty results
mxstbr Jan 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@

// Add your own contribution below

* Add support for failing the build without outputting any text - mxstbr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be something more like:

Builds which only use markdown now only show the markdown, and no violations table is shown - mxstbr

Which makes a bit more sense without the context of this PR 👍


### 0.10.0

* Adds support for running Danger against a PR locally - orta

The workflow is that you find a PR that exhibits the behavior you'd like Danger to run against,
The workflow is that you find a PR that exhibits the behavior you'd like Danger to run against,
then edit the local `Dangerfile.js` and run `yarn run danger pr https://github.com/facebook/jest/pull/2629`.

This will post the results to your console, instead of on the PR itself.
Expand All @@ -19,8 +21,8 @@ This will post the results to your console, instead of on the PR itself.

* Adds support for `git.commits` and `git.luolix.topmits` - orta

Why two? Well git.luolix.topmits contains a bunch of github specific metadata ( e.g. GitHub user creds,
commit comment counts. ) Chances are, you're always going to use `git.commits` however if you
Why two? Well git.luolix.topmits contains a bunch of github specific metadata ( e.g. GitHub user creds,
commit comment counts. ) Chances are, you're always going to use `git.commits` however if you
want more rich data, the GitHub one is available too. Here's an example:

```js
Expand Down
2 changes: 1 addition & 1 deletion source/runner/templates/github-issue-template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import * as v from "voca"
* @returns {string} HTML
*/
function table(name: string, emoji: string, violations: Array<Violation>): string {
if (violations.length === 0) { return "" }
if (violations.length === 0 || (violations.length === 1 && !violations[0].message)) { return "" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get a test on this logic, as this is not something which would get manually tested very often

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This area is already pretty well covered, so it should be pretty trivial to C&P an existing one

return `
<table>
<thead>
Expand Down