Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: 404 Page #202

Closed
danielschuster-muc opened this issue Oct 5, 2022 Discussed in #172 · 12 comments
Closed

[Feature Request]: 404 Page #202

danielschuster-muc opened this issue Oct 5, 2022 Discussed in #172 · 12 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@danielschuster-muc
Copy link
Owner

danielschuster-muc commented Oct 5, 2022

Discussed in #172

Originally posted by danielschuster-muc October 1, 2022

Project

Website (Potter DB Search)

Describe the feature you want to request

When you get to a page that is not found, you will see a very empty 404 page.

(Optional) Describe a solution for this feature

Edit the 404 page inspired by the image below.

The title of the page should be Have you seen this page?.
In the middle the image with Sirius and below a paragraph with Approach with extreme caution! To not attempt to use magic against this site!
There should also be a button to go back to the homepage.

Make sure to follow the style of other page, use MUI and proper credit the image of Sirius in the Attribution file.

image

@PeritusDeveloper
Copy link

I want to do this

@kirtanchandak
Copy link

Hey, can I take this issue ?

@danielschuster-muc
Copy link
Owner Author

@PeritusDeveloper on which issue are you currently working? #202 or #204?
Maybe @kirtanchandak can work on one of those, as you are currently assigned to two issues?

@kirtanchandak
Copy link

@danielschuster-muc are these Hacktoberfest issue ? as you have removed the Hacktoberfest tag from it

@danielschuster-muc
Copy link
Owner Author

@danielschuster-muc are these Hacktoberfest issue ? as you have removed the Hacktoberfest tag from it

All issues / PRs count automatically for hacktoberfest, as this repository is labeled with hacktoberfest.
But please wait for @PeritusDeveloper's reply before working on this feature request.

@PeritusDeveloper
Copy link

I am about to finish both
I will submit both by evening tomorrow
If I dont you can assign any one to other person

@danielschuster-muc
Copy link
Owner Author

Sure, no problem. It can also take a bit longer if you need the time. It's just important for me to know whether people are still working on their features, so I can organise it better.

@kirtanchandak
Copy link

kirtanchandak commented Oct 9, 2022

as @PeritusDeveloper is working on this issue, can you assign me the other one

@danielschuster-muc
Copy link
Owner Author

I will submit both by evening tomorrow
That sounds for like he is working on both.

@PeritusDeveloper
Copy link

@danielschuster-muc you can assign him this issue
it's fine for me
I will do the navbar one

@danielschuster-muc
Copy link
Owner Author

You still working on it @kirtanchandak? Or should I unassign you?

@kirtanchandak
Copy link

Hey, I am working on this

@danielschuster-muc danielschuster-muc linked a pull request Nov 26, 2022 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants