404 Error page #346
Closed
404 Error page #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| return ( | ||
| <div> | ||
| <Typography variant="h3">Have You Seen this page?</Typography> | ||
| <img |
There was a problem hiding this comment.
Can you use next/image instead of the default img tag?
There was a problem hiding this comment.
And with this, could you also improve the image for mobile usage?
| <Typography variant="h3">Have You Seen this page?</Typography> | ||
| <img | ||
| src="https://user-images.githubusercontent.com/90754725/194039761-45ed2b6c-aa69-4070-b1df-6ca2ef90cb48.png" | ||
| alt="" |
There was a problem hiding this comment.
and alt tag would be also very useful.
Comment on lines
+12
to
+15
| <Typography variant="body1"> | ||
| Approach with extreme caution! To not attempt to use magic against this | ||
| site! | ||
| </Typography> |
There was a problem hiding this comment.
Instead of the text and the title about the image, can you maybe integrate it on the image? Maybe just use the image of sirius on the newspaper thing and put the text on it?
Or maybe something similar?
|
|
||
| const NotFound = () => { | ||
| return <Typography variant="h3">404 - Page Not Found</Typography>; | ||
| return ( | ||
| <div> |
There was a problem hiding this comment.
Can you also center the whole thing? And maybe put it in a Card Component?
danielschuster-muc
requested changes
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type