Fix issue #1

[sambragg]

Fix Issue #1

DRY up codebase by removing duplicate TypeError code from each operation and bring into the _check function. Invoke the _check() function before each operation.

[danthareja]

Yay, a pull request!

After you submit a pull request, one of the following will happen:

😭 You don’t get a response. 😭

Even on an active project, it’s possible that your pull request won’t get an immediate response. You should expect some delay as most open source maintainers do so in their free time and can be busy with other tasks.

If you haven’t gotten a response in over a week, it’s fair to politely respond in the same thread, asking someone for a review. If you know the handle of the right person to review your pull request, you can @-mention them to send them a notification. Avoid reaching out to that person privately; remember that public communication is vital to open source projects.

If you make a polite bump and still nobody responds, it’s possible that nobody will respond, ever. It’s not a great feeling, but don’t let that discourage you. It’s happened to everyone! There are many possible reasons why you didn’t get a response, including personal circumstances that may be out of your control. Try to find another project or way to contribute. If anything, this is a good reason not to invest too much time in making a pull request before other community members are engaged and responsive.

🚧 You're asked to make changes to your pull request. 🚧

It’s very common that someone will request changes on your pull request, whether that’s feedback on the scope of your idea, or changes to your code. Often a pull request is just the start of the conversation.

When someone requests changes, be responsive. They’ve taken the time to review your pull request. Opening a PR and walking away is bad form. If you don’t know how to make changes, research the problem, then ask for help if you need it.

If you don’t have time to work on the issue anymore (for example, if the conversation has been going on for months, and your circumstances have changed), let the maintainer know so they’re not expecting a response. Someone else may be happy to take over.

👎 Your pull request doesn’t get accepted. 👎

It's possible your pull request may or may not be accepted in the end. If you’re not sure why it wasn’t accepted, it’s perfectly reasonable to ask the maintainer for feedback and clarification. Ultimately, however, you’ll need to respect that this is their decision. Don’t argue or get hostile. You’re always welcome to fork and work on your own version if you disagree!

🎉 Your pull request gets accepted and merged. 🎉

Hooray! You’ve successfully made an open source contribution!

---

Thank you for the submission, @sambragg! I'll review your code shortly, hang tight.

[danthareja]

LGTM, @sambragg 👍

[danthareja]

🎉 You did it! 🎉

You're an open source contributor now!

Whether this was your first pull request, or you’re just looking for new ways to contribute, I hope you’re inspired to take action. Don't forget to say thanks when a maintainer puts effort into helping you, even if a contribution doesn't get accepted.

Remember, open source is made by people like you: one issue, pull request, comment, and +1 at a time.

What's next?

Find your next project:

• Up For Grabs - a list of projects with beginner-friendly issues
• First Timers Only - a list of bugs that are labelled "first-timers-only"
• Awesome-for-beginners - a GitHub repo that amasses projects with good bugs for new contributors, and applies labels to describe them.
• YourFirstPR - starter issues on GitHub that can be easily tackled by new contributors.
• Issuehub.io - a tool for searching GitHub issues by label and language

Learn from other great community members:

• "How to contribute to an open source project on github" by @kentcdodds
• "Bring Kindness Back to Open Source" by @shanselman
• "Getting into Open Source for the First Time" by @mcdonnelldean
• "How to find your first open source bug to fix" by @Shubheksha
• "How to Contribute to Open Source" by @Github
• "Make your first open source contribution in 5 minutes" by @Roshanjossey

Elevate your Git game:

• Try git - an interactive Git tutorial made by GitHub
• Atlassian Git Tutorials - various tutorials on using Git
• Git Cheat Sheet - PDF made by GitHub
• GitHub Flow - YouTube video explaining how to make a pull request on GitHub talk on how to make a pull request
• Oh shit, git! - how to get out of common Git mistakes described in plain English

Questions? Comments? Concerns?

I'm always open to feedback. If you had a good time with the exercise, or found some room for improvement, please let me know on twitter or email.

Want to start over? Just delete your fork.
Want to see behind the scenes? Check out the server code.

[danthareja]

Hello again, @sambragg! I want to congratulate you again for completing this challenge. Hopefully you've started to get out there and apply your knowledge to another project.

Since you haven't pushed a commit in a while, I'm going to delete your branch in order to make room for others actively particiating. You'll still have access to your fork, but you won't be able to submit anymore pull requests to this branch.

Don't worry though! If you decide that you do want a new branch, you can delete your fork and re-fork the original project.

Happy Hacking!