-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRY up the codebase #1
Labels
Comments
Merged
Merged
ghost
mentioned this issue
Nov 20, 2017
Merged
Closed
Open
Merged
i am working on it and facing eslint problems since i am working on windows do i need to take care special care? |
@sourabh1031, are they the same problems you mentioned in your other issue danthareja/contribute-to-open-source-server#2? If so, did you try what I mentioned in the reply? |
Yes it got solved by your help thanks and now I must switch my work onto
Unix based system isn't?
…On Jan 14, 2018 9:32 AM, "Dan Thareja" ***@***.***> wrote:
@sourabh1031 <https://github.com/sourabh1031>, are they the same problems
you mentioned in your other issue danthareja/contribute-to-open-
source-server#2
<danthareja/contribute-to-open-source-server#2>?
If so, did you try what I mentioned in the reply?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AYZ7Y0xcUkBTZhPexCCeW7PjDoWCAEsQks5tKXxmgaJpZM4QVZhc>
.
|
No need. As long as the styling issues are fixed, you can keep developing on Windows. |
Merged
Merged
Merged
Closed
Merged
DrJuneau
added a commit
to DrJuneau/contribute-to-open-source
that referenced
this issue
Mar 22, 2018
dantharejabot
added a commit
that referenced
this issue
Mar 22, 2018
Resolve Issue #1 - Dry up the database
Sourav-Kumar-bit
added a commit
to Sourav-Kumar-bit/contribute-to-open-source
that referenced
this issue
Dec 23, 2023
This was referenced Feb 8, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
negraop
added a commit
to negraop/contribute-to-open-source
that referenced
this issue
Jul 1, 2024
brijesh-989
added a commit
to brijesh-989/contribute-to-open-source
that referenced
this issue
Jul 4, 2024
benjammin4dayz
added a commit
to benjammin4dayz/contribute-to-open-source
that referenced
this issue
Jul 18, 2024
* Implement _check function * Enable test to assert _check
dantharejabot
added a commit
that referenced
this issue
Jul 18, 2024
Refactor calculator, enable test; fix #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're off to an amazing start disrupting the calculator industry. Our beautiful contributors burned all of last week's midnight oil to release our first version and the initial reception has been unprecedented!
After a code review from some experts, we've learned that there's some unnecessary repetition in the codebase. Removing this repetition will make our codebase easier to maintain as we continue to grow into the world's best calculator company.
The team is burnt out from last week's push and needs your help! Before blowing half of our capital investment on a vacation in the Swiss Alps, the team managed to write some tests for this refactor, and left behind a roadmap to the next big release:
describe.skip
todescribe.only
npm test
_check
to make the tests passdescribe.only
todescribe
so all the tests runnpm test
againThe text was updated successfully, but these errors were encountered: