Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dried up the codebase #27

Closed
wants to merge 1 commit into from

Conversation

protean-phoenix
Copy link

fixed #1
Moved identical code for checking that parameter types are numbers to one function, exports._check, and used the function in places where the duplicate code once existed.

@danthareja
Copy link
Owner

Thanks for the submission, @protean-phoenix.

As mentioned in the contributing guidelines, I can only accept a pull request made to your branch. This behavior deviates from most projects (where a pull request to the master branch may be expected) in order to replicate this experience for multiple people.

Click here to open this pull request to your branch

@danthareja danthareja closed this Nov 21, 2017
@darkranger778 darkranger778 mentioned this pull request Feb 5, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DRY up the codebase
2 participants