Bug Fix and Enhancement: Volume Size Calculation (#1875)

* Remove redundant check for undefined volume sizes * Refactor volume size calculation to handle null or undefined values explicitly
dappnode · Mar 11, 2024 · 63236dc · 63236dc
1 parent 6d29218
commit 63236dc
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/packages/admin-ui/src/pages/packages/components/Info/VolumesList.tsx b/packages/admin-ui/src/pages/packages/components/Info/VolumesList.tsx
@@ -79,10 +79,8 @@ export const VolumesList = ({ dnp }: { dnp: InstalledPackageDetailData }) => {
     return null;
   }
 
-  const isTotalVolumeSizeIllDefined = volumes.some(v => !v.size);
-
   const totalVolumeSize = volumes.reduce(
-    (total, vol) => total + (vol.size || 0),
+    (total, vol) => (vol.size != null ? total + vol.size : total),
     0
   );
 
@@ -104,7 +102,7 @@ export const VolumesList = ({ dnp }: { dnp: InstalledPackageDetailData }) => {
           </span>
         </span>
         <span>
-          {isTotalVolumeSizeIllDefined ? "-" : prettyBytes(totalVolumeSize)}
+          {prettyBytes(totalVolumeSize)}
         </span>
 
         <BsTrash