Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix and Enhancement: Volume Size Calculation #1875

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

GiselleNessi
Copy link
Contributor

This pull request addresses a bug related to volume size calculation in packages and introduces an enhancement for better code clarity.

Changes include:

  • Fixed volume size calculation logic to handle null or undefined values, ensuring accurate aggregation across packages.
  • Removed redundant checks for undefined volume sizes, streamlining rendering and enhancing code clarity.

These changes aim to improve the reliability and maintainability of volume size calculations within the application.

@GiselleNessi GiselleNessi self-assigned this Mar 8, 2024
@GiselleNessi GiselleNessi linked an issue Mar 8, 2024 that may be closed by this pull request
@github-actions github-actions bot temporarily deployed to commit March 8, 2024 11:29 Inactive
Copy link

github-actions bot commented Mar 8, 2024

Copy link

github-actions bot commented Mar 8, 2024

DAppNode bot has built and pinned the release to an IPFS node, for commit: 119002e

This is a development version and should only be installed for testing purposes, install link

/ipfs/QmbLL7E8DPo5RaDexZ28DsM3NtnMVkRdmpTiwSVPL8py8q

(by dappnodebot/build-action)

@GiselleNessi GiselleNessi marked this pull request as ready for review March 8, 2024 13:33
@GiselleNessi GiselleNessi requested a review from a team as a code owner March 8, 2024 13:33
@pablomendezroyo pablomendezroyo merged commit 63236dc into develop Mar 11, 2024
8 checks passed
@pablomendezroyo pablomendezroyo deleted the gi/volumes-size branch March 11, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packages size view fails
2 participants