Telegram channel id on ethical metrics implementation #1890
Conversation
…/DNP_DAPPMANAGER into mateu/telegram-channel-id-input
|
DAppNode bot has built and pinned the release to an IPFS node, for commit: 291bb63 This is a development version and should only be installed for testing purposes, install link (by dappnodebot/build-action) |
| try { | ||
| setValidationMessage("Enabling ethical metrics..."); | ||
| await api.enableEthicalMetrics({ | ||
| mail: mailValue || mail, |
There was a problem hiding this comment.
This is weird, use just one value
| setValidationMessage("Enabling ethical metrics..."); | ||
| await api.enableEthicalMetrics({ | ||
| mail: mailValue || mail, | ||
| tgChannelId: tgChannelIdValue || tgChannelId, |
|
|
||
| async function enableEthicalMetricsSync({ | ||
| mailValue, | ||
| tgChannelIdValue |
There was a problem hiding this comment.
consider using the useStates instead of function arguments
| await api.enableEthicalMetrics({ | ||
| mail: mailValue || mail, | ||
| tgChannelId: tgChannelIdValue || tgChannelId, | ||
| sync: true |
There was a problem hiding this comment.
Have you test the behaviour of setting this with option sync to true? Take into account that this might be the onboarding and might take some time the user would not like to wait during setting up dappnode
| }) | ||
| } | ||
| variant="dappnode" | ||
| disabled={ |
There was a problem hiding this comment.
could you try to simplify this condition?
There was a problem hiding this comment.
it looks a bit complex
| ) : ( | ||
| <SwitchBig | ||
| disabled={ | ||
| (tgChannelId === "" && mail === "") || |
packages/admin-ui/src/pages/system/components/Notifications/EthicalMetrics.tsx
Show resolved
Hide resolved
| } catch (e) { | ||
| setReqStatusDisable({ error: e }); | ||
| console.error("Error on registerEthicalMetrics", e); | ||
| } | ||
| } | ||
|
|
||
| function enableEthicalSwitch() { |
There was a problem hiding this comment.
I dont get this, its useless to have a function that just calls another function. Remove it if possible
| Update | ||
| </Button> | ||
| ) : ( | ||
| <></> |
There was a problem hiding this comment.
Dont add an empty element, instead use above the operator ethicalMetricsOn && ( )
There was a problem hiding this comment.
TypeScript can have issues inferring the correct type. Using undefined instead of an empty fragment is often clearer in terms of intent maybe?
packages/admin-ui/src/pages/system/components/Notifications/EthicalMetrics.tsx
Show resolved
Hide resolved
…e button disabling. Implemented 5s validation display.
…ified Ethical metrics changes
Ethical metrics enhancement modal
Inputs for the telegram id added in the system / notifications section, and also in the onboarding modal of ethical metrics.
Welcome Modal:
System > Notifications:
These changes aim to empower users with more control over their notifications while maintaining privacy and enhancing the overall user experience.