Add MEV-Boost package to Stakers Holesky #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiselleNessi
changed the title
|
DAppNode bot has built and pinned the release to an IPFS node, for commit: ae1f3f0 This is a development version and should only be installed for testing purposes, install link (by dappnodebot/build-action) |
dappnodedev
requested changes
Mar 22, 2024
dappnodedev
reviewed
Mar 25, 2024
| @@ -233,7 +233,7 @@ export default function StakerNetwork<T extends Network>({ | |||
| isSelected={newEnableWeb3signer} | |||
| /> | |||
| </Col> | |||
| {(network === "prater" || network === "mainnet") && ( | |||
| {(network === "prater" || network === "mainnet" || network === "holesky") && ( | |||
There was a problem hiding this comment.
Probably there is a better way to do this. Something like:
["prater", "mainnet", "holesky"].includes(network)
(research a bit on the best way to do it)
There was a problem hiding this comment.
The use of Array.includes() makes the condition more expressive and self-explanatory. It clearly communicates the intent of checking whether the network value is among a predefined list of valid networks. So it is a better approach for readability, maintainability, and flexibility of the code.
Marketen
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see issue #1865
This pull request adds support for the Holesky testnet to MEV-Boost, including integration of working relays for Flashbots, Aestus, and Ultrasound networks. Additionally, it ensures a consistent user experience across different networks, mirroring the UX of MEV-Boost on other platforms. With Prater nearing deprecation and its relays no longer maintained, this update is crucial for seamless transition and continued functionality.