Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Docsy config to fix GitHub links in any submodule docs #1895

Closed
AaronCrawfis opened this issue Nov 1, 2021 · 1 comment · Fixed by dapr/go-sdk#435, dapr/php-sdk#138, dapr/python-sdk#582, dapr-sandbox/components-dotnet-sdk#36 or #3659
Closed

Update Docsy config to fix GitHub links in any submodule docs #1895

AaronCrawfis opened this issue Nov 1, 2021 · 1 comment · Fixed by dapr/go-sdk#435, dapr/php-sdk#138, dapr/python-sdk#582, dapr-sandbox/components-dotnet-sdk#36 or #3659
Assignees
@AaronCrawfis
Labels
content/new-feature New feature or request P1 website/functionality

Comments

@AaronCrawfis
Copy link
Collaborator

Today the "Open issue" and "Edit in GitHub" buttons are broken for submodule repos (SDKs, translations, etc.).

We should use the new Docsy capability to cascade the repo link down to fix this: https://www.docsy.dev/docs/adding-content/repository-links/#path_base_for_github_subdir-optional
This was referenced Jul 13, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@AaronCrawfis
Copy link
Collaborator Author

@hhunter-ms / @msfussell these PRs should all together fix this issue

@hhunter-ms hhunter-ms mentioned this issue Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AaronCrawfis AaronCrawfis

Labels
content/new-feature New feature or request P1 website/functionality
Projects
None yet
Milestone
No milestone
1 participant
@AaronCrawfis