Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cascading metadata #138

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

AaronCrawfis
Copy link
Contributor

Description

Adds cascading metadata so the docs GitHub links work as expected in the sidebar

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to
implementation.

Partially fixes dapr/docs#1895

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Tests pass
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #138 (aacaa7c) into main (d17e37e) will increase coverage by 0.32%.
The diff coverage is n/a.

❗ Current head aacaa7c differs from pull request most recent head ce9c398. Consider uploading reports for the commit ce9c398 to get more accurate results

@@             Coverage Diff              @@
##               main     #138      +/-   ##
============================================
+ Coverage     73.48%   73.80%   +0.32%     
  Complexity      562      562              
============================================
  Files            72       72              
  Lines          1746     1718      -28     
============================================
- Hits           1283     1268      -15     
+ Misses          463      450      -13     

see 10 files with indirect coverage changes

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit f0f37c3 into dapr:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Docsy config to fix GitHub links in any submodule docs
3 participants