Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cascading docs metadata #513

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

AaronCrawfis
Copy link
Contributor

@AaronCrawfis AaronCrawfis commented Jul 13, 2023

Adds cascading metadata to the docs so edit/view buttons work as expected

Partially addresses dapr/docs#1895

Signed-off-by: Aaron Crawfis Aaron.Crawfis@microsoft.com

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
@AaronCrawfis AaronCrawfis requested review from a team as code owners July 13, 2023 22:31
@AaronCrawfis AaronCrawfis changed the title Add docs metadata Add cascading docs metadata Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #513 (985b772) into main (b1a6efb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   35.22%   35.22%           
=======================================
  Files          90       90           
  Lines       10142    10142           
  Branches      415      415           
=======================================
  Hits         3573     3573           
  Misses       6503     6503           
  Partials       66       66           

@shubham1172
Copy link
Member

Without cascading docs:
image

With cascading docs:
image

@AaronCrawfis the JS SDK link seems to be broken.

@AaronCrawfis
Copy link
Contributor Author

@AaronCrawfis the JS SDK link seems to be broken.

@shubham1172 this PR will need to be merged first: dapr/docs#3612

The path_base_for_github_subdir Docsy parameter wasn't introduced until recently, which the main Dapr docs repo hasn't updated yet. The docs PR brings in the one partial template into the docs repo so the URL will be generated correctly. If you switch your docs branch to aacrawfi/meta-template it should generate as expected.

@shubham1172
Copy link
Member

Thanks, it works now.
image

@shubham1172 shubham1172 added this pull request to the merge queue Jul 15, 2023
Merged via the queue into dapr:main with commit d20b7dd Jul 15, 2023
@AaronCrawfis AaronCrawfis deleted the aacrawfi/docs-metadata branch July 17, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants