Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #269 dev container broken on M1/ARM #270

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Sep 2, 2021

Description

Python-sdk dev container breaks during docker build for 2 reasons:

  • it baselines on an older base image python37 which is not bullseye based
  • it hardcodes amd64 architecture

The fix simply changes the base image to a newer one that is bullseye based, and second makes the architecture parameter dynamic based on your machine.

Issue reference

Please reference the issue this PR will close: #269

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests -- passes 'tox -e py39'
  • Extended the documentation N/A

@paulyuk paulyuk requested review from a team as code owners September 2, 2021 17:20
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #270 (8355e0e) into master (aba8ed4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   89.28%   89.28%           
=======================================
  Files          52       52           
  Lines        2155     2155           
=======================================
  Hits         1924     1924           
  Misses        231      231           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba8ed4...8355e0e. Read the comment docs.

Copy link

@CodeMonkeyLeet CodeMonkeyLeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcs1only wcs1only merged commit d939242 into dapr:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev container build breaks on Mac M1
3 participants