feat(chore): adapt to storages usage of protobuf
#538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teal-sprinkles-4c7f14 canceled.
|
mohammed90
force-pushed
the
gob-to-protobuf
branch
2 times, most recently
from
32d57e3
to
11bacb5
Compare
|
I tried making the tests pass with replacements. It doesn't work 😅 I guess I have to wait for the other PR. |
mohammed90
force-pushed
the
gob-to-protobuf
branch
from
11bacb5
to
f84440a
Compare
Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
mohammed90
force-pushed
the
gob-to-protobuf
branch
from
f84440a
to
07573f2
Compare
darkweak
force-pushed
the
gob-to-protobuf
branch
from
a213cfd
to
c47f50b
Compare
darkweak
force-pushed
the
gob-to-protobuf
branch
2 times, most recently
from
78a234d
to
c5c126e
Compare
darkweak
force-pushed
the
gob-to-protobuf
branch
from
c5c126e
to
3e6dfc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on darkweak/storages#8 and requires amendment after merging the
storagesPR.I noticed the
tykpackage still depends on the older API of Souin which hasstorageswithin Souin repo. I left it as-is, though it'll require minor changes to work. I can do it if it was missed from before.