feat(chore): optimize encoded cache value #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammed90
force-pushed
the
gob-to-protobuf
branch
4 times, most recently
from
aa1a8e1
to
b50e6e3
Compare
Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
mohammed90
force-pushed
the
gob-to-protobuf
branch
from
b50e6e3
to
fc2e175
Compare
Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
mohammed90
force-pushed
the
gob-to-protobuf
branch
from
04a9716
to
cc41522
Compare
Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
|
Thank you @mohammed90 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current encoding of cache value for storage is
encoding/gob. It is known to be inefficient in comparison to other serialization formats. This PR changes the serialization from gob to protocol buffers for efficiency. Although protobuf may not be the most efficient serialization format, it is popular thus ensures support and bug fixes will continue.The use of Buf is to ease the pain of compiling protobuf files. Given the simplicity of the use case, I opted not to use the common and often recommendation of versioning and splitting the packages. I doubt the format will change drastically in a breaking manner.
Souin PR darkweak/souin#538