Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

co19/LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t08 #2739

Closed
scheglov opened this issue Jul 1, 2024 · 0 comments
Closed
Assignees
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@scheglov
Copy link

scheglov commented Jul 1, 2024

FAILED: dart2analyzer-none release_arm64 co19/LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t08
Expected: Pass
Actual: MissingCompileTimeError

--- Command "dart2analyzer" (took 20ms):
DART_CONFIGURATION=ReleaseARM64 sdk/bin/dart --packages=.dart_tool/package_config.json pkg/analyzer_cli/bin/analyzer.dart --use-analysis-driver-memory-byte-store --dart-sdk=/Users/scheglov/Source/Dart/sdk.git/sdk/sdk -Dtest_runner.configuration=custom-configuration-1 --enable-experiment=macros --ignore-unrecognized-flags --packages=/Users/scheglov/Source/Dart/sdk.git/sdk/.dart_tool/package_config.json --format=json /Users/scheglov/Source/Dart/sdk.git/sdk/tests/co19/src/LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t08.dart

static error failures:
- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t08_lib.dart line 32, column 14, length 1.

- Unexpected error at tests/co19/src/LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t08.dart line 30, column 10, length 3: COMPILE_TIME_ERROR.INVALID_OVERRIDE

- Unexpected error at tests/co19/src/LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t08.dart line 45, column 10, length 3: COMPILE_TIME_ERROR.INVALID_OVERRIDE

--- Re-run this test:
python3 tools/test.py -m release -c dart2analyzer -a arm64 co19/LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t08

For

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t08_lib.dart line 32, column 14, length 1.

We don't report anything on I1 or I2 in E because there is String foo() => "E"; in E.
Which we report as

- Unexpected error at tests/co19/src/LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t08.dart line 45, column 10, length 3: COMPILE_TIME_ERROR.INVALID_OVERRIDE

For

- Unexpected error at tests/co19/src/LanguageFeatures/Augmentation-libraries/augmenting_types_A07_t08.dart line 30, column 10, length 3: COMPILE_TIME_ERROR.INVALID_OVERRIDE

We report an error here because String foo() => "С1"; is no a valid override of I2.foo.

@sgrekhov sgrekhov self-assigned this Jul 2, 2024
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Jul 2, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 2, 2024
@eernstg eernstg closed this as completed in 675f7a4 Jul 2, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jul 8, 2024
2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2759. Update expected errors positions (dart-lang/co19#2760)
2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2756. Fix the new roll failures (dart-lang/co19#2758)
2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2756. Fix the new roll failures (dart-lang/co19#2757)
2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2754. Fix some of the new roll failures (dart-lang/co19#2755)
2024-07-05 sgrekhov22@gmail.com dart-lang/co19#2559. Add missing `augmented` to operators tests (dart-lang/co19#2753)
2024-07-05 sgrekhov22@gmail.com dart-lang/co19#2559. More augmented expressions tests for operators (dart-lang/co19#2752)
2024-07-04 sgrekhov22@gmail.com dart-lang/co19#2559. Add more test cases for augmented expression (dart-lang/co19#2750)
2024-07-03 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting declarations tests (dart-lang/co19#2565)
2024-07-03 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests (dart-lang/co19#2749)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2741. Update expected errors locations in augmenting_types_A07_t10.dart (dart-lang/co19#2747)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2742. Update expected errors locations in augmenting types tests (dart-lang/co19#2748)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2740. Update expected errors locations (dart-lang/co19#2746)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2739. Update expected errors locations (dart-lang/co19#2745)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2734. Fix object identity tests for web platforms (dart-lang/co19#2744)
2024-07-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.6 to 4.1.7 in the github-actions group (dart-lang/co19#2743)
2024-07-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2734. Don't expect nan to be identical on web platforms (dart-lang/co19#2737)
2024-07-01 sgrekhov22@gmail.com dart-lang/co19#2559. Add more test cases for augmented expression (dart-lang/co19#2738)
2024-07-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2732. Add missing implementation of an inherited interface (dart-lang/co19#2735)
2024-07-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2733. Expect errors reported on a merged class (dart-lang/co19#2736)
2024-07-01 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting expressions tests (dart-lang/co19#2731)
2024-07-01 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests (dart-lang/co19#2723)
2024-06-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2726. Update expected errors positions (dart-lang/co19#2727)
2024-06-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2529. Add test checking wildcard parameter with no default value (dart-lang/co19#2730)
2024-06-28 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests (dart-lang/co19#2722)
2024-06-28 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for operators. Part 1 (dart-lang/co19#2724)
2024-06-28 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for operators. Part 2 (dart-lang/co19#2728)

Change-Id: I86f5bc77bce1c539789132606fa806082afbf7c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/374682
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Development

No branches or pull requests

2 participants