Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2559. Add more augmented expression tests #2749

Merged
merged 2 commits into from
Jul 3, 2024
Merged

#2559. Add more augmented expression tests #2749

merged 2 commits into from
Jul 3, 2024

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Jul 2, 2024

No description provided.

eernstg
eernstg reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I added a couple of comments about the terminology, and one test seems to have some cases that don't bring anything new.

(We should probably go more into checks about redundancy, in order to avoid making the test runs too expensive, but we can hopefully do more about that when we get some kind of support for coverage.)

LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t01_lib.dart
// ^^^^^^^^^
// [analyzer] unspecified
// [cfe] unspecified
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extension types can have static variables, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to add extension types to these tests after resolution of dart-lang/language#3694

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be OK to add extension type cases now, and then later on add cases where the extra freedom (e.g., leaving out the primary constructor) is used. I don't think anyone suggested that #3694 should give rise to fewer possible programs.

I'll land this now, and then those extension type cases can be added in a different PR, now or later.

LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t02_lib.dart Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t04_lib.dart Outdated Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t05_lib.dart Outdated Show resolved Hide resolved
sgrekhov
sgrekhov commented Jul 2, 2024
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. PTAL

LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t01_lib.dart
// ^^^^^^^^^
// [analyzer] unspecified
// [cfe] unspecified
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to add extension types to these tests after resolution of dart-lang/language#3694

LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t02_lib.dart Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmented_expression_A09_t05_lib.dart Outdated Show resolved Hide resolved
@sgrekhov sgrekhov requested a review from eernstg July 2, 2024 20:29
eernstg
eernstg approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit ce04289 into dart-lang:master Jul 3, 2024
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jul 8, 2024
@sgrekhov
[co19] Roll co19 to 8dce0f0cf47e9dc1b756b1c1602369842797468a
6d33ca2 
2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2759. Update expected errors positions (dart-lang/co19#2760)
2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2756. Fix the new roll failures (dart-lang/co19#2758)
2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2756. Fix the new roll failures (dart-lang/co19#2757)
2024-07-05 sgrekhov22@gmail.com Fixes dart-lang/co19#2754. Fix some of the new roll failures (dart-lang/co19#2755)
2024-07-05 sgrekhov22@gmail.com dart-lang/co19#2559. Add missing `augmented` to operators tests (dart-lang/co19#2753)
2024-07-05 sgrekhov22@gmail.com dart-lang/co19#2559. More augmented expressions tests for operators (dart-lang/co19#2752)
2024-07-04 sgrekhov22@gmail.com dart-lang/co19#2559. Add more test cases for augmented expression (dart-lang/co19#2750)
2024-07-03 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting declarations tests (dart-lang/co19#2565)
2024-07-03 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests (dart-lang/co19#2749)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2741. Update expected errors locations in augmenting_types_A07_t10.dart (dart-lang/co19#2747)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2742. Update expected errors locations in augmenting types tests (dart-lang/co19#2748)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2740. Update expected errors locations (dart-lang/co19#2746)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2739. Update expected errors locations (dart-lang/co19#2745)
2024-07-02 sgrekhov22@gmail.com Fixes dart-lang/co19#2734. Fix object identity tests for web platforms (dart-lang/co19#2744)
2024-07-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.6 to 4.1.7 in the github-actions group (dart-lang/co19#2743)
2024-07-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2734. Don't expect nan to be identical on web platforms (dart-lang/co19#2737)
2024-07-01 sgrekhov22@gmail.com dart-lang/co19#2559. Add more test cases for augmented expression (dart-lang/co19#2738)
2024-07-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2732. Add missing implementation of an inherited interface (dart-lang/co19#2735)
2024-07-01 sgrekhov22@gmail.com Fixes dart-lang/co19#2733. Expect errors reported on a merged class (dart-lang/co19#2736)
2024-07-01 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting expressions tests (dart-lang/co19#2731)
2024-07-01 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests (dart-lang/co19#2723)
2024-06-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2726. Update expected errors positions (dart-lang/co19#2727)
2024-06-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2529. Add test checking wildcard parameter with no default value (dart-lang/co19#2730)
2024-06-28 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests (dart-lang/co19#2722)
2024-06-28 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for operators. Part 1 (dart-lang/co19#2724)
2024-06-28 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmented expression tests for operators. Part 2 (dart-lang/co19#2728)

Change-Id: I86f5bc77bce1c539789132606fa806082afbf7c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/374682
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgrekhov @eernstg