Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LanguageFeatures/Simple-bounds tests according to https://github.com/dart-lang/language/pull/1133 #942

Closed
iarkh opened this issue Sep 24, 2020 · 5 comments
Assignees

Comments

@iarkh
Copy link
Contributor

iarkh commented Sep 24, 2020

dart-lang/language#1133 has been landed, and this means that any test that expects a compile-time error because of a failing i2b that is caused by a type variable which is invariant or unused should be changed to stop expecting that error.

Simple-bounds tests should be updated accordingly.

@eernstg
Copy link
Member

eernstg commented Sep 24, 2020

I added a bunch of comments on f07abdd, having noted that several of the tests need to have their expectations adjsted.

@eernstg
Copy link
Member

eernstg commented Sep 28, 2020

Correction (also mentioned in existing comment threads on the PR): Tests LanguageFeatures/Simple-bounds/static/typedef_l1_t04.dart and LanguageFeatures/Simple-bounds/static/typedef_l1_t14.dart are correct in f07abdd after all.

@iarkh
Copy link
Contributor Author

iarkh commented Sep 28, 2020

Correction (also mentioned in existing comment threads on the PR): Tests LanguageFeatures/Simple-bounds/static/typedef_l1_t04.dart and LanguageFeatures/Simple-bounds/static/typedef_l1_t14.dart are correct in f07abdd after all.

I'll go through new comments for f07abdd and check it again today. After this update the tests if still it's needed (maybe not)..

@eernstg
Copy link
Member

eernstg commented Sep 28, 2020

Thanks!

@iarkh
Copy link
Contributor Author

iarkh commented Sep 28, 2020

Just checked it once again and add a minor change, seems like the tests are OK now...

@iarkh iarkh closed this as completed in 53dd55a Sep 29, 2020
@iarkh iarkh self-assigned this Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants