Add null-safety specification of super-bounded types #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheglov
reviewed
Aug 5, 2020
scheglov
reviewed
Aug 13, 2020
|
Tests under development here. |
leafpetersen
approved these changes
Sep 11, 2020
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 15, 2020
See dart-lang/language#1133 Change-Id: I3800b88496a8bf214b4bc366f4cb7ef3e9968f17 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162784 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This was referenced Sep 22, 2020
This was referenced Sep 24, 2020
|
Tests under review here. |
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 8, 2021
The update is specified in the following: dart-lang/language#1133 Change-Id: I2850b1acf7c94b8174c21cf899c9b926a03d9cc8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175726 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
iarkh
added a commit
to dart-lang/co19
that referenced
this pull request
Jan 28, 2021
iarkh
added a commit
to dart-lang/co19
that referenced
this pull request
Jan 28, 2021
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 22, 2021
2021-02-22 whesse@google.com Fix syntax error in test expectation in ffi test (#1002) 2021-02-20 irina.arkhipets@gmail.com #1000: Missing Issue tags added. 2021-02-20 irina.arkhipets@gmail.com Issue #1000: tests updated according to the recent result analysis 2021-02-20 sgrekhov@unipro.ru Roll failures fixed 2021-02-19 sgrekhov@unipro.ru #999. Missed experiment flags added 2021-02-19 sgrekhov@unipro.ru #993. 32 and 64-bit integer tests added 2021-02-19 sgrekhov@unipro.ru #993. Change test to expect compile error if struct subclass created by the constructor 2021-02-19 sgrekhov@unipro.ru #993. Remove tests that run "nm" command 2021-02-18 sgrekhov@unipro.ru #993. More ffi tests added 2021-02-18 irina.arkhipets@gmail.com Instantiate-to-bounds tests apdated according to the SDK Issues 44223, 42446 evaluation. 2021-02-17 irina.arkhipets@gmail.com Issue #535: nnbd-strong requirement added to the tests, more tests for constant evaluation and canonicalization added. 2021-02-17 sgrekhov@unipro.ru Some of type aliases tests fixed 2021-02-17 sgrekhov@unipro.ru #993. More Struct tests added 2021-02-16 irina.arkhipets@gmail.com Issue #535: more tests for constant evaluation and canonicalization added. 2021-02-12 irina.arkhipets@gmail.com Fixes #994: test expectesions updated according to the recent SDK changes. 2021-02-12 sgrekhov@unipro.ru #993. More Struct tests added 2021-02-12 irina.arkhipets@gmail.com Merge remote-tracking branch 'origin/master' 2021-02-12 sgrekhov@unipro.ru #993. NativeType and Struct tests added 2021-02-11 irina.arkhipets@gmail.com Fixes #991: tests updated according to the recent SDK changes. 2021-02-08 sgrekhov@unipro.ru #993. sizeOf() tests added 2021-02-05 sgrekhov@unipro.ru #993. More tests for DynamicLibrary added 2021-02-04 sgrekhov@unipro.ru #993. DynamicLibrary constructors tests added 2021-02-03 sgrekhov@unipro.ru #993. co19 ffi tests. Initial commit 2021-02-02 sgrekhov@unipro.ru Fixes #992. Boolean conditional evaluation tests added 2021-02-01 irina.arkhipets@gmail.com Fixes #990: tests updated according to the recent SDK changes. 2021-01-28 irina.arkhipets@gmail.com Fixes #979: I-2-b tests updated according to the recent changes for dart-lang/language#1133 2021-01-28 irina.arkhipets@gmail.com Fixes #984: I-2-b tests updated according to the recent changes for dart-lang/language#1133 2021-01-27 sgrekhov@unipro.ru Fixes #989. Runtime type equality operator tests added 2021-01-26 irina.arkhipets@gmail.com Fixes #988: Static warning checks corrected. 2021-01-25 sgrekhov@unipro.ru Fixes #987. Local variables and inference tests added Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,analyzer-nnbd-mac-release-try,analyzer-nnbd-win-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,front-end-nnbd-mac-release-x64-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-ia32-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-debug-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-debug-x64-try,vm-kernel-nnbd-win-release-ia32-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try Change-Id: I78ba37f9c74d2afc360ef5fbd51d01ab75239fd6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186146 Reviewed-by: Jonas Termansen <sortie@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a section to the null-safety specification specifying how to determine whether a given type is correctly super-bounded.