Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frogsh: multiline string constants don't handle embedded escaped quote marks correctly #1002

Closed
DartBot opened this issue Dec 29, 2011 · 2 comments
Closed

frogsh: multiline string constants don't handle embedded escaped quote marks correctly #1002

DartBot opened this issue Dec 29, 2011 · 2 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js

Comments

@DartBot
Copy link

DartBot commented Dec 29, 2011

This issue was originally filed by jackpa...@google.com

Repro steps:

frogsh bug.dart

Expected:

Prints """z"""

Actual:

node.js:201
        throw e; // process.nextTick error, or 'error' event on first tick
              ^
SyntaxError: Unexpected token ILLEGAL
    at minfrog_main (/Users/jackpal/code/dart/dart/frog/xcodebuild/Release_ia32/frog/bin/frogsh:26440:10)
    at main (/Users/jackpal/code/dart/dart/frog/xcodebuild/Release_ia32/frog/bin/frogsh:26451:3)
    at Object.<anonymous> (/Users/jackpal/code/dart/dart/frog/xcodebuild/Release_ia32/frog/bin/frogsh:26951:1)
    at Module._compile (module.js:432:26)
    at Object..js (module.js:450:10)
    at Module.load (module.js:351:31)
    at Function._load (module.js:310:12)
    at Array.0 (module.js:470:10)
    at EventEmitter._tickCallback (node.js:192:40)

Attachment:
bug.dart (236 Bytes)
@anders-sandholm
Copy link
Contributor

Removed Area-Frog label.
Added Area-Dart2JS, FromAreaFrog labels.

@kasperl
Copy link

kasperl commented Jun 12, 2012

Added WontFix label.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
dart-bot pushed a commit that referenced this issue Feb 22, 2021
@whesse
[co19] Roll co19 to 88b4f0556b0889067efcac45f2b96bc630e5b96c
1771245 
2021-02-22 whesse@google.com Fix syntax error in test expectation in ffi test (#1002)
2021-02-20 irina.arkhipets@gmail.com #1000: Missing Issue tags added.
2021-02-20 irina.arkhipets@gmail.com Issue #1000: tests updated according to the recent result analysis
2021-02-20 sgrekhov@unipro.ru Roll failures fixed
2021-02-19 sgrekhov@unipro.ru #999. Missed experiment flags added
2021-02-19 sgrekhov@unipro.ru #993. 32 and 64-bit integer tests added
2021-02-19 sgrekhov@unipro.ru #993. Change test to expect compile error if struct subclass created by the constructor
2021-02-19 sgrekhov@unipro.ru #993. Remove tests that run "nm" command
2021-02-18 sgrekhov@unipro.ru #993. More ffi tests added
2021-02-18 irina.arkhipets@gmail.com Instantiate-to-bounds tests apdated according to the SDK Issues 44223, 42446 evaluation.
2021-02-17 irina.arkhipets@gmail.com Issue #535: nnbd-strong requirement added to the tests, more tests for constant evaluation and canonicalization added.
2021-02-17 sgrekhov@unipro.ru Some of type aliases tests fixed
2021-02-17 sgrekhov@unipro.ru #993. More Struct tests added
2021-02-16 irina.arkhipets@gmail.com Issue #535: more tests for constant evaluation and canonicalization added.
2021-02-12 irina.arkhipets@gmail.com Fixes #994: test expectesions updated according to the recent SDK changes.
2021-02-12 sgrekhov@unipro.ru #993. More Struct tests added
2021-02-12 irina.arkhipets@gmail.com Merge remote-tracking branch 'origin/master'
2021-02-12 sgrekhov@unipro.ru #993. NativeType and Struct tests added
2021-02-11 irina.arkhipets@gmail.com Fixes #991: tests updated according to the recent SDK changes.
2021-02-08 sgrekhov@unipro.ru #993. sizeOf() tests added
2021-02-05 sgrekhov@unipro.ru #993. More tests for DynamicLibrary added
2021-02-04 sgrekhov@unipro.ru #993. DynamicLibrary constructors tests added
2021-02-03 sgrekhov@unipro.ru #993. co19 ffi tests. Initial commit
2021-02-02 sgrekhov@unipro.ru Fixes #992. Boolean conditional evaluation tests added
2021-02-01 irina.arkhipets@gmail.com Fixes #990: tests updated according to the recent SDK changes.
2021-01-28 irina.arkhipets@gmail.com Fixes #979: I-2-b tests updated according to the recent changes for dart-lang/language#1133
2021-01-28 irina.arkhipets@gmail.com Fixes #984: I-2-b tests updated according to the recent changes for dart-lang/language#1133
2021-01-27 sgrekhov@unipro.ru Fixes #989. Runtime type equality operator tests added
2021-01-26 irina.arkhipets@gmail.com Fixes #988: Static warning checks corrected.
2021-01-25 sgrekhov@unipro.ru Fixes #987. Local variables and inference tests added

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,analyzer-nnbd-mac-release-try,analyzer-nnbd-win-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,front-end-nnbd-mac-release-x64-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-ia32-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-debug-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-debug-x64-try,vm-kernel-nnbd-win-release-ia32-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: I78ba37f9c74d2afc360ef5fbd51d01ab75239fd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186146
Reviewed-by: Jonas Termansen <sortie@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @kasperl @anders-sandholm @DartBot