Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support the new super mixins #1752

Closed
devoncarew opened this issue Sep 5, 2018 · 4 comments
Closed

support the new super mixins #1752

devoncarew opened this issue Sep 5, 2018 · 4 comments
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures status-blocked Blocked from making progress by another (referenced) issue type-enhancement A request for a change that isn't a bug

Comments

@devoncarew
Copy link
Member

The overall tracking issue is here: dart-lang/language#12.

This is the dartdoc specific issue for supporting the new super mixins feature.

@jcollins-g jcollins-g added P1 A high priority bug; for example, a single project is unusable or has many test failures status-blocked Blocked from making progress by another (referenced) issue labels Sep 11, 2018
@jcollins-g
Copy link
Contributor

Marking as blocked until at least some level of support in analyzer (dart-lang/sdk#34164) is available.

@jcollins-g jcollins-g added the type-enhancement A request for a change that isn't a bug label Sep 11, 2018
@jcollins-g
Copy link
Contributor

Still blocked for completion (will require a version of build to be published that supports the new analyzer as well). However, I have wired this up enough now to know that the new analyzer support works well enough to treat the new mixin declarations as ordinary classes.

I think the right thing to do here is to treat these similarly to how we treat enums; as a special type of class with different labeling.

@jcollins-g
Copy link
Contributor

Landing this, and a dartdoc publish is blocked on this: dart-lang/build#1873 and a new analyzer publish which should happen in the next day or so.

@jcollins-g
Copy link
Contributor

As pointed out in dart-lang/build#1873, there is a workaround available for us to publish without new build versions, so we're really only blocked for certain on a new analyzer publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures status-blocked Blocked from making progress by another (referenced) issue type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants