Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #230: links with unbalanced parentheses #231

Closed
wants to merge 3 commits into from
Closed

Fix #230: links with unbalanced parentheses #231

wants to merge 3 commits into from

Conversation

tomyeh
Copy link
Contributor

@tomyeh tomyeh commented Aug 10, 2018

As described in dart-lang/tools#1398

srawlins
srawlins approved these changes Aug 10, 2018
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! Thanks for the quick fix! After a quick dartfmt, you should be done!

@kevmoo
Copy link
Member

kevmoo commented Oct 22, 2018

What's the story here?

@kevmoo
Copy link
Member

kevmoo commented Mar 25, 2019

@tomyeh ping? Care to rebase?

@kevmoo kevmoo mentioned this pull request Mar 25, 2019
Merged
@kevmoo
Copy link
Member

kevmoo commented Mar 25, 2019

Closing and running with this on #241 – thanks @tomyeh

@kevmoo kevmoo closed this Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomyeh @kevmoo @srawlins @googlebot