Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links #241

Merged
merged 3 commits into from
Mar 26, 2019
Merged

Fix links #241

merged 3 commits into from
Mar 26, 2019

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Mar 25, 2019

Fix dart-lang/tools#1398 - links with unbalanced parentheses
Fix dart-lang/tools#1399 - exception on invalid link

@kevmoo kevmoo requested a review from srawlins March 25, 2019 21:19
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@kevmoo
Copy link
Member Author

kevmoo commented Mar 25, 2019

@srawlins – let me handle the merge here

I'm going to close #231

@kevmoo kevmoo mentioned this pull request Mar 25, 2019
Closed
@kevmoo
Copy link
Member Author

kevmoo commented Mar 26, 2019

@srawlins ?

@srawlins
Copy link
Member

Still says cla: no :( Do you mean the merge after I approve?

@kevmoo
Copy link
Member Author

kevmoo commented Mar 26, 2019

I'm going to squash merge so the CLA won't matter. These are trivial changes.

@kevmoo kevmoo merged commit 6329387 into master Mar 26, 2019
@kevmoo kevmoo deleted the pull/231 branch March 26, 2019 17:09
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 9, 2024
@kevmoo
Fix links (dart-lang/markdown#241)
0c1c09d 
* Fixes dart-lang/markdown#230: links with unbalanced parentheses
* Fixes dart-lang/markdown#233: exception on invalid link
* fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
cla: no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LinkSyntax doesn't parse incorrect link syntax well Links with unbalanced parentheses cause an exception
4 participants
@kevmoo @googlebot @srawlins @tomyeh