Pana may wish to consider docs coverage in the score (or at least list as a warning)

[eseidelGoogle]

Flutter for example tracks that all public members in flutter/flutter are documented.

flutter analyze --flutter-repo --dartdocs is the command we use.

Which just turns on:
http://dart-lang.github.io/linter/lints/package_api_docs.html

[isoos]

I think this could be part of the code health (vs. the other option is maintenance).

Question: given a package with great documentation with 100/100 health score, if you'd remove all of the API docs, how much would you decrease its score? What would be a "fair" percentage for it?

[kwalrath]

90/100? There's a tradeoff between encouraging doc comments and people gaming the system by writing unhelpful doc comments just to increase the score.

[isoos]

For the first iteration, we could do the following

• Run dartdoc.
• After a successful dartdoc run, we'll get an index.json, that contains all the public entry points of the API. Counting them gives us the apiCount.
• When we run dartanalyzer, we can turn on the public_member_api_docs linter rule. The number of the reported issues gives us the missingDocCount.
• health (Fitness) needs to be adjusted with these, although there is already an "api size estimate" in the current Fitness.magnitude.

This does not handle empty documentation, nor does it take the method size into account, e.g. the following will be counted as one missing API entry point out of the many...

///
void method() {}

[kevmoo]

FYI: public_member_api_docs seems to be (very) broken - dart-lang/sdk#57310

[kwalrath]

How hard should we be on packages that don't rely on dartdoc-generated docs as their primary reference docs?

I'm thinking of angular_components, which relies on the gallery at https://dart-lang.github.io/angular_components_example rather than API docs, since you usually use the components via HTML rather than Dart.

I suppose we can detect these packages by whether they have a non-blank documentation field in their pubspec.

/cc @nshahan @TedSander

[kwalrath]

Thinking about this some more, there's a hierarchy of doc importance:

1. README (used for API doc homepage; crucially important; has multiple audiences: API doc readers, package page readers, github site visitors)
2. library description (every library should have one, maybe even if the library isn't included in API docs by default)
3. class description (every important class should have one; ideally, all classes should give or point to a little context about when you might need the class and what other classes you should consider instead)
4. member descriptions (not always necessary; better to have no description than boilerplate)

[nshahan]

I see a lot of instances where a library contains a single class. Typically there isn't a library doc. All the documentation is on the class. @kwalrath WDYT?

[kwalrath]

@nshahan I can see how that might be reasonable for packages that have tons of very small libraries, where the API isn't primarily Dart. It's not a great experience for people who happen to find the package or library docs, though.

[isoos]

I have a very early-version PoC of using package:dartdoc to extract the documentation text (thanks @jcollins-g for the help). We could use the same thing for various purposes: to indicate in the analysis if a package is under-documented, and also to include it in the search when documentation is present.

The catch is: the analysis part (building the PackageGraph in dartdoc) takes over a minute for a package like pana, and it is repeated when we are generating docs for the package. This would mean that the average package analysis time would be 3-4x the current times.

The balancing act here is that we want the analysis upgrades to be fast (e.g. when there is a version / data schema change), and it needs to be figured out how this can be done on the pub site's scale. (/cc @jakobr-google)

[kevmoo]

Maybe we have another score that is the doc score and we separate that out from pana.

Pana is relatively straight-forward now. Adding dartdoc as an integration point would add a lot of complexity.

One could argue dartdoc could "learn" how to give a score when it generates docs...

[isoos]

Good points! There is also the potential that we can introduce new scoring segments in the near future, so it would be worth to re-think how we shall store and update the scores.

[isoos]

Follow-up: I'm implementing a data extraction from package:dartdoc in dart-lang/pub-dev#1353. This will be the basis of the dartdoc coverage score (and also the input for search), but it won't be through pana.

[kevmoo]

ack

…

On Wed, Jun 6, 2018 at 7:15 AM István Soós ***@***.***> wrote: Follow-up: I'm implementing a data extraction from package:dartdoc in dart-lang/pub-dev#1353 <dart-lang/pub-dev#1353>. This will be the basis of the dartdoc coverage score (and also the input for search), but it won't be through pana. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#269 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABCikjHt6VS8BUC6P3Th0MTQp4idF48ks5t5-PpgaJpZM4SufgP> .

[isoos]

This has been implemented for a while now.