Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move *SDK environments into a single ToolEnvironment class. #289

Merged
merged 1 commit into from
Apr 13, 2018

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Apr 13, 2018

This is the first step of refactoring for #269 (among others). Running pub global run dartdoc requires us change back and forth between using a local and a global PUB_CACHE, and I would like to tidy up these runtime-related functions before implementing that.

@isoos isoos requested a review from jakobr-google April 13, 2018 06:58
Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isoos isoos merged commit 9dabdef into dart-lang:master Apr 13, 2018
@isoos isoos deleted the tool_env_1 branch April 13, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants