Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating Summary.licenseFile and Summary.licenses to AnalysisResult.licenses #1385

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jul 3, 2024

  • Deprecated classes and fields that will become obsolete.
  • Added new licenses field to AnalysisResult.
  • The change is an overdue migration that also cleans up a half-migration of LicenseFile.
  • I've considered to use another class name instead of reusing License, but the name seems to be fit, and its migration would be too complicated. We just won't need to remove the path field, and we may add confidence classification or score later to it. (An upcoming breaking change should clean up these loose threads.)

@isoos isoos merged commit 635a3ff into dart-lang:master Jul 5, 2024
5 checks passed
@isoos isoos deleted the licenses branch July 5, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants